Strangler-Refactoring der PAYONE-Zahlungslogik in eine testbare
Service-Schicht, ohne Verhalten in Checkout/Cron/IPN zu ändern.
Neue Services (app/Services/Payment/Payone):
- PayonePaymentService (+ PayonePaymentResult-DTO) für CC-/SEPA-Check
und Abo-Abbuchung
- PayoneRequestBuilder, PaymentMethodResolver, PayoneMethodConfig
- PayoneTransactionRecorder: zentrale PaymentTransaction-Erstellung
(API-Response, Invoice, Webhook) inkl. PCI-Redaction (cardpan/cardcvc2)
- PayoneWebhookHandler (+ PayoneWebhookResult): IPN/TSOK-Logik aus
Api\PayoneController; response('TSOK') statt echo/exit
- PayoneTransportException + Handler-Mapping (403) statt abort() im Service
Hotfixes (R1): var_dump/exit & bare exit() entfernt, Log-Redaction.
Security (R-Review):
- PAYONE_KEY_HASH (MD5-Hash, kein Klartext) mit Boot-Hard-Fail; schließt
zugleich die ''-Webhook-Bypass-Lücke. Artisan-Command payone:hash-key
(verdeckte Eingabe, optional --write) zur Hash-Erzeugung.
- Webhook: txaction Pflichtfeld, mode-Fallback auf payment->mode.
Pay\PayoneController ist @deprecated-Fassade (614 → 328 Zeilen),
delegiert an Services via Container-Singleton.
Migration: fehlende Spalte shopping_payments.carddata nachgezogen.
Tests: 47 grün (PayonePaymentService, Recorder, Webhook, Resolver,
TransportException, hash-key). End-to-End im Test-System verifiziert
(siehe dev/2026-06-09-payments).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
23 lines
730 B
PHP
23 lines
730 B
PHP
<?php
|
|
|
|
use App\Exceptions\Handler;
|
|
use App\Services\Payment\Payone\Exceptions\PayoneTransportException;
|
|
use Illuminate\Http\Request;
|
|
use Tests\TestCase;
|
|
|
|
uses(TestCase::class);
|
|
|
|
it('renders an uncaught PayoneTransportException as a 403 response', function (): void {
|
|
$handler = app(Handler::class);
|
|
$request = Request::create('/checkout', 'POST');
|
|
|
|
$response = $handler->render($request, new PayoneTransportException('Fehlercode: 1002'));
|
|
|
|
expect($response->getStatusCode())->toBe(403);
|
|
});
|
|
|
|
it('does not report PayoneTransportException (no duplicate exception mail)', function (): void {
|
|
$handler = app(Handler::class);
|
|
|
|
expect($handler->shouldReport(new PayoneTransportException('x')))->toBeFalse();
|
|
});
|