gitmedia/presseportale
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

5.2: gemeinsamen Firmen-Sync-Kern als User::syncCompaniesWithRoles() gezogen

Browse source 
Analyse der beiden ~40/160-Zeilen-save()-Methoden (users/create vs edit): sie
teilen nur den User-Attribut-Payload und den byte-identischen Firmen-Sync-Loop
(Bearbeiten hat zusaetzlich Profil/Kontakte/volle Billing-CRUD). Ein voller
UserUpsertService waere Over-Engineering (ueberwiegend Branches) — daher nur
der wirklich gemeinsame Persistenz-Kern:

User::syncCompaniesWithRoles(array $companyIds, array $roles) baut das
Pivot-Payload (fehlende Rolle => 'member') und synct. Beide Formulare nutzen
es; im Bearbeiten kommen die linkedCompanyIds nun direkt aus $validated.

Test: UserSyncCompaniesTest (Rollen-Zuordnung, member-Default, Detach).
29 User-Tests gruen.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Kevin Adametz 2026-07-02 08:47:23 +00:00
parent 6b1d84fc01
commit 1729e35943
4 changed files with 57 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/Feature/UserSyncCompaniesTest.php Normal file
View file

@ -0,0 +1,35 @@
<?php
use App\Models\Company;
use App\Models\User;
test('syncCompaniesWithRoles attaches companies with their pivot role', function () {
$user = User::factory()->create();
$a = Company::factory()->create();
$b = Company::factory()->create();
$user->syncCompaniesWithRoles([$a->id, $b->id], [$a->id => 'owner', $b->id => 'responsible']);
expect($user->companies()->pluck('role', 'companies.id')->all())
->toBe([$a->id => 'owner', $b->id => 'responsible']);
});
test('syncCompaniesWithRoles defaults missing roles to member', function () {
$user = User::factory()->create();
$company = Company::factory()->create();
$user->syncCompaniesWithRoles([$company->id], []);
expect($user->companies()->first()->pivot->role)->toBe('member');
});
test('syncCompaniesWithRoles detaches companies no longer listed', function () {
$user = User::factory()->create();
$a = Company::factory()->create();
$b = Company::factory()->create();
$user->syncCompaniesWithRoles([$a->id, $b->id], []);
$user->syncCompaniesWithRoles([$b->id], [$b->id => 'owner']);
expect($user->companies()->pluck('companies.id')->all())->toBe([$b->id]);
});