gitmedia/presseportale
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

legacy: privatize-media überspringt unmigrierte Legacy-Bildzeilen, --prune-missing löscht sie

Browse source 
Der Legacy-Import legt pro Alt-Bild eine Zeile mit rohem Legacy-Dateinamen
als path an; legacy:migrate-media biegt sie auf die echte Datei um. Zeilen,
deren Datei im Alt-System verloren ging (Live-Befund: ~22k bei Presseecho),
blieben als disk=public-Leichen liegen und ließen den Privatizer mit
RuntimeException abbrechen. Jetzt: Skip + Warnhinweis statt Abbruch;
--prune-missing löscht solche Zeilen endgültig, wenn ihre Datei auf keiner
Disk existiert. Der Integritäts-Assert für migrierte Pfade bleibt.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Kevin Adametz 2026-07-20 10:50:31 +00:00
parent a1302994c5
commit 3151b1f38a
3 changed files with 115 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

54
tests/Feature/PressReleaseMediaPrivatizerTest.php
View file

@ -1,6 +1,7 @@
<?php
use App\Models\PressRelease;
use App\Models\PressReleaseImage;
use App\Services\PressRelease\PressReleaseMediaPrivatizer;
use Illuminate\Support\Facades\Storage;
@ -40,6 +41,59 @@ test('existing public press release media is moved to private storage', function
->and($attachment->fresh()->disk)->toBe('local');
});
test('unmigrated legacy image rows are skipped instead of aborting the run', function () {
Storage::fake('public');
Storage::fake('local');
$pressRelease = PressRelease::factory()->create();
$legacyImage = $pressRelease->images()->create([
'disk' => 'public',
'path' => 'b0cde51ff6799356bfaa8ec4c80e8921.jpg',
'legacy_portal' => 'presseecho',
'legacy_id' => 33683,
]);
$migratedImage = $pressRelease->images()->create([
'disk' => 'public',
'path' => "press-releases/{$pressRelease->id}/images/cover.jpg",
]);
Storage::disk('public')->put($migratedImage->path, 'content');
$this->artisan('press-releases:privatize-media')
->expectsOutputToContain('1 unmigrierte Legacy-Bildzeilen übersprungen')
->assertSuccessful();
expect($legacyImage->fresh())->not->toBeNull()
->and($legacyImage->fresh()->disk)->toBe('public')
->and($migratedImage->fresh()->disk)->toBe('local');
});
test('prune-missing deletes unmigrated legacy image rows only when no file exists', function () {
Storage::fake('public');
Storage::fake('local');
$pressRelease = PressRelease::factory()->create();
$lostImage = $pressRelease->images()->create([
'disk' => 'public',
'path' => 'b0cde51ff6799356bfaa8ec4c80e8921.jpg',
'legacy_portal' => 'presseecho',
'legacy_id' => 33683,
]);
$recoverableImage = $pressRelease->images()->create([
'disk' => 'public',
'path' => 'noch-vorhanden.jpg',
'legacy_portal' => 'presseecho',
'legacy_id' => 33684,
]);
Storage::disk('public')->put($recoverableImage->path, 'content');
$this->artisan('press-releases:privatize-media', ['--prune-missing' => true])
->expectsOutputToContain('1 unmigrierte Legacy-Bildzeilen ohne Datei wurden gelöscht.')
->expectsOutputToContain('1 unmigrierte Legacy-Bildzeilen übersprungen')
->assertSuccessful();
expect(PressReleaseImage::withTrashed()->find($lostImage->id))->toBeNull()
->and($recoverableImage->fresh())->not->toBeNull()
->and($recoverableImage->fresh()->disk)->toBe('public');
});
test('a missing source file never flips its database record to the private disk', function () {
Storage::fake('public');
Storage::fake('local');