gitmedia/presseportale
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

R1.1: Buchungs-Gate geprueft + safe-by-default; Legacy-Buchungspfade festgeschrieben

Browse source 
Default von billing.enforce_booking auf true gedreht: ein in Produktion
vergessener Env-Key haette das Gate sonst still geoeffnet (jeder haette
ohne Zahlung veroeffentlichen koennen). Tests ergaenzt: Grandfathered
gueltig/abgelaufen/NULL (= abgelaufen, Entscheidung 19.06.), Active
ausserhalb der Periode, Service-Level-Submit mit Legacy-Buchung und
BookingRequiredException ohne Buchung. Scope-Logik selbst war korrekt.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Kevin Adametz 2026-07-03 08:07:01 +00:00
parent 8653abdeec
commit c9641e9184
4 changed files with 109 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

59
tests/Feature/Billing/HasActiveBookingTest.php
View file

@ -73,3 +73,62 @@ test('a cancelled legacy agreement does not count as booking', function () {
expect($user->hasActiveBooking())->toBeFalse();
});
test('an active legacy agreement outside its current period does not count as booking', function () {
$user = User::factory()->create();
UserPaymentOption::factory()->create([
'user_id' => $user->id,
'payment_option_id' => PaymentOption::factory()->create()->id,
'status' => UserPaymentOptionStatus::Active->value,
'current_period_start' => now()->subMonths(2)->startOfMonth(),
'current_period_end' => now()->subMonths(2)->endOfMonth(),
'grandfathered_until' => null,
'stripe_subscription_id' => null,
]);
expect($user->hasActiveBooking())->toBeFalse();
});
test('a grandfathered agreement with valid protection counts as booking', function () {
$user = User::factory()->create();
UserPaymentOption::factory()->create([
'user_id' => $user->id,
'payment_option_id' => PaymentOption::factory()->create()->id,
'status' => UserPaymentOptionStatus::Grandfathered->value,
'grandfathered_until' => now()->addYear(),
'stripe_subscription_id' => null,
]);
expect($user->hasActiveBooking())->toBeTrue();
});
test('a grandfathered agreement with expired protection does not count as booking', function () {
$user = User::factory()->create();
UserPaymentOption::factory()->create([
'user_id' => $user->id,
'payment_option_id' => PaymentOption::factory()->create()->id,
'status' => UserPaymentOptionStatus::Grandfathered->value,
'grandfathered_until' => now()->subDay(),
'stripe_subscription_id' => null,
]);
expect($user->hasActiveBooking())->toBeFalse();
});
test('a grandfathered agreement without an end date does not count as booking', function () {
// NULL = abgelaufen/ungültig (User-Entscheidung 19.06.2026).
$user = User::factory()->create();
UserPaymentOption::factory()->create([
'user_id' => $user->id,
'payment_option_id' => PaymentOption::factory()->create()->id,
'status' => UserPaymentOptionStatus::Grandfathered->value,
'grandfathered_until' => null,
'stripe_subscription_id' => null,
]);
expect($user->hasActiveBooking())->toBeFalse();
});