Legacy-API-Kunden mit Keys beider Altportale — vor allem connektar — senden jede Meldung an presseecho.de UND businessportal24.de. Weil die Firma ihr Portal vom User und die Meldung es von der Firma erbte, landeten beide Kopien im selben Portal, die zweite mit Slug-Suffix "-2". Verifiziert wurde das über die Token-Hashes gegen die Legacy-Datenbanken. Das Portal wird jetzt in fester Reihenfolge aufgelöst: expliziter portal-Parameter, sonst die aufgerufene Domain, sonst das Portal des Firmenprofils, zuletzt Portal::Both — genau der Default, den beide Spalten ohnehin tragen. Die Auflösung ist damit nicht-nullbar; vorher konnte sie null liefern, was als SQL-Fehler und damit als 500er beim Alt-Client gelandet wäre. Ein Update über die v1-API verschiebt eine bestehende Meldung ausschließlich über den expliziten Parameter, nie über die aufgerufene Domain. press-releases:fix-api-portal-duplicates repariert die Altdaten: Es findet Paare (gleicher User, Titel, Sprache und Portal, beide per API eingereicht, kurz nacheinander) und verschiebt die zweite Kopie samt ihrer exklusiven Firma ins jeweils andere Portal, mit neu vergebenem Slug. Web-Doppel-Submits ohne Status-Log source=api und Legacy-Sync-Daten mit gesetzter legacy_id werden geschont. Auf Live ausgeführt und verifiziert. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
154 lines
6.1 KiB
PHP
154 lines
6.1 KiB
PHP
<?php
|
|
|
|
use App\Enums\Portal;
|
|
use App\Models\Company;
|
|
use App\Models\PressRelease;
|
|
use App\Models\User;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* Tests zum Reparatur-Command für den API-Portal-Bug (13.08.2026):
|
|
* Duplikat-Paare (gleicher User/Titel, gleiches Portal, per API kurz
|
|
* nacheinander eingereicht) — die zweite Kopie wandert samt exklusiver
|
|
* Firma ins andere Portal, Slugs werden dort suffixfrei neu vergeben.
|
|
*/
|
|
function apiDuplicatePair(User $user, string $title, string $slugBase): array
|
|
{
|
|
$createdAt = now()->subHour();
|
|
|
|
$pair = [];
|
|
|
|
foreach ([0, 1] as $index) {
|
|
$company = Company::factory()->businessportal24()->create([
|
|
'owner_user_id' => $user->id,
|
|
'name' => 'Firma '.$title,
|
|
'slug' => $index === 0 ? 'firma-'.$slugBase : 'firma-'.$slugBase.'-2',
|
|
]);
|
|
|
|
$pressRelease = PressRelease::factory()
|
|
->forPortal(Portal::Businessportal24)
|
|
->published()
|
|
->create([
|
|
'user_id' => $user->id,
|
|
'company_id' => $company->id,
|
|
'title' => $title,
|
|
'slug' => $index === 0 ? $slugBase : $slugBase.'-2',
|
|
'created_at' => $createdAt->copy()->addSeconds($index * 20),
|
|
]);
|
|
|
|
$pressRelease->statusLogs()->create([
|
|
'from_status' => 'draft',
|
|
'to_status' => 'review',
|
|
'source' => 'api',
|
|
'created_at' => $pressRelease->created_at,
|
|
]);
|
|
|
|
$pair[] = $pressRelease;
|
|
}
|
|
|
|
return $pair;
|
|
}
|
|
|
|
test('moves the second api duplicate with its company to the other portal', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['portal' => Portal::Businessportal24]);
|
|
[$original, $duplicate] = apiDuplicatePair($user, 'Doppelt gesendete Meldung', 'doppelt-gesendete-meldung');
|
|
|
|
$this->artisan('press-releases:fix-api-portal-duplicates')
|
|
->assertSuccessful();
|
|
|
|
$original->refresh();
|
|
$duplicate->refresh();
|
|
|
|
expect($original->portal)->toBe(Portal::Businessportal24)
|
|
->and($original->slug)->toBe('doppelt-gesendete-meldung')
|
|
->and($duplicate->portal)->toBe(Portal::Presseecho)
|
|
->and($duplicate->slug)->toBe('doppelt-gesendete-meldung');
|
|
|
|
expect($original->company()->withoutGlobalScopes()->first()->portal)->toBe(Portal::Businessportal24)
|
|
->and($duplicate->company()->withoutGlobalScopes()->first()->portal)->toBe(Portal::Presseecho)
|
|
->and($duplicate->company()->withoutGlobalScopes()->first()->slug)->toBe('firma-doppelt-gesendete-meldung');
|
|
});
|
|
|
|
test('dry run reports but changes nothing', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['portal' => Portal::Businessportal24]);
|
|
[, $duplicate] = apiDuplicatePair($user, 'Trockenlauf Meldung', 'trockenlauf-meldung');
|
|
|
|
$this->artisan('press-releases:fix-api-portal-duplicates', ['--dry-run' => true])
|
|
->assertSuccessful();
|
|
|
|
expect($duplicate->refresh()->portal)->toBe(Portal::Businessportal24)
|
|
->and($duplicate->slug)->toBe('trockenlauf-meldung-2');
|
|
});
|
|
|
|
test('ignores web double submits without api status log', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['portal' => Portal::Presseecho]);
|
|
$company = Company::factory()->presseecho()->create(['owner_user_id' => $user->id]);
|
|
|
|
$pressReleases = collect([0, 1])->map(fn (int $index) => PressRelease::factory()
|
|
->forPortal(Portal::Presseecho)
|
|
->create([
|
|
'user_id' => $user->id,
|
|
'company_id' => $company->id,
|
|
'title' => 'Doppelklick im Formular',
|
|
'slug' => $index === 0 ? 'doppelklick-im-formular' : 'doppelklick-im-formular-2',
|
|
'created_at' => now()->subMinutes(10)->addSeconds($index * 3),
|
|
]));
|
|
|
|
$this->artisan('press-releases:fix-api-portal-duplicates')
|
|
->assertSuccessful();
|
|
|
|
expect($pressReleases[1]->refresh()->portal)->toBe(Portal::Presseecho)
|
|
->and($pressReleases[1]->slug)->toBe('doppelklick-im-formular-2');
|
|
});
|
|
|
|
test('ignores legacy synced press releases and pairs outside the time window', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['portal' => Portal::Businessportal24]);
|
|
[, $duplicate] = apiDuplicatePair($user, 'Legacy Sync Meldung', 'legacy-sync-meldung');
|
|
$duplicate->forceFill(['legacy_id' => 987654, 'legacy_portal' => 'businessportal24'])->save();
|
|
|
|
[, $lateDuplicate] = apiDuplicatePair($user, 'Späte zweite Meldung', 'spate-zweite-meldung');
|
|
$lateDuplicate->forceFill(['created_at' => now()->subHour()->addHours(3)])->save();
|
|
|
|
$this->artisan('press-releases:fix-api-portal-duplicates')
|
|
->assertSuccessful();
|
|
|
|
expect($duplicate->refresh()->portal)->toBe(Portal::Businessportal24)
|
|
->and($lateDuplicate->refresh()->portal)->toBe(Portal::Businessportal24);
|
|
});
|
|
|
|
test('shared companies stay untouched when the duplicate moves', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['portal' => Portal::Businessportal24]);
|
|
$sharedCompany = Company::factory()->businessportal24()->create(['owner_user_id' => $user->id]);
|
|
|
|
$pressReleases = collect([0, 1])->map(function (int $index) use ($user, $sharedCompany) {
|
|
$pressRelease = PressRelease::factory()
|
|
->forPortal(Portal::Businessportal24)
|
|
->create([
|
|
'user_id' => $user->id,
|
|
'company_id' => $sharedCompany->id,
|
|
'title' => 'Meldung mit Stammfirma',
|
|
'slug' => $index === 0 ? 'meldung-mit-stammfirma' : 'meldung-mit-stammfirma-2',
|
|
'created_at' => now()->subHour()->addSeconds($index * 20),
|
|
]);
|
|
|
|
$pressRelease->statusLogs()->create([
|
|
'from_status' => 'draft',
|
|
'to_status' => 'review',
|
|
'source' => 'api',
|
|
'created_at' => $pressRelease->created_at,
|
|
]);
|
|
|
|
return $pressRelease;
|
|
});
|
|
|
|
$this->artisan('press-releases:fix-api-portal-duplicates')
|
|
->assertSuccessful();
|
|
|
|
expect($pressReleases[1]->refresh()->portal)->toBe(Portal::Presseecho)
|
|
->and($sharedCompany->refresh()->portal)->toBe(Portal::Businessportal24);
|
|
});
|