Bilder (N01, N05, N07, N08): gemeinsamer Freigabezustand PressReleaseImage::isPubliclyDeliverable() für Seiten, OG und Medienroute (Bestand bleibt sichtbar, v2 nur mit Bestätigung, Admin-Upload bis zum Kundenklick nicht öffentlich); eigene Ability confirmImageRights nur für den Kontoinhaber, ohne Super-Admin-Kurzschluss, Identität und ausstehende Bestätigung auch im Service; Status-Regel unter der PM-Sperre; Cache-Flush nach dem Commit außerhalb der Dateibereinigung; Snapshot nach Bestätigung an veröffentlichter PM; Bestätigungstexte an die gezeigte Kennung gebunden. Beweisarchiv (N02, N10, N11, N12, N13, 5.1): Tombstone unter Zeilensperre mit erneuter Hold-/Fristprüfung; Dateioperationen ausgewertet, Commands mit FAILURE; record() über .tmp + move; Marker archive_pending_at mit archive:retry-pending und archive:sweep-orphans; Anonymisierung entfernt Bilder über den Remover mit Antragsbezug; Draft-Purge räumt Medien nie veröffentlichter abgelehnter Einreichungen; App-Kopien fallen mit dem Archiv-Tombstone; label_corrected nur für veröffentlichte Bilder; archive_entries.legal_request_id; FileDeletion-Helfer; Systemstatus-Checks. KI und Hintergrund (N03, N04, N14, N20, N21): Ergebnis-UPDATE und Audit in einer Transaktion; erwarteter Hash bis in reject()/holdForManualReview(); Ablaufmail per beanspruchtem Marker in einer Transaktion; strikte Schemaprüfung der Vision-Antwort; Fortschrittsmarke ungecacht. Berichte und Canonical (N15–N19, 5.2): lückenlose Alterskohorten; Feed-Identität mit Portal und Sprache; Sitemap-Rolle in der Kundenansicht; Indexverteilung auf einer Grundgesamtheit; Kopien nach Wegfall der Erstquelle neu bewertet; Kategorie-Admin leert Seiten-Caches; Dry-Run zählt alle Tabellen. Gesamtsuite: 2.122 Tests grün, einer übersprungen; Larastan und Pint sauber. Zwei Migrationen (nullable Spalten, INSTANT). N09 offen. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
220 lines
9.3 KiB
PHP
220 lines
9.3 KiB
PHP
<?php
|
|
|
|
use App\Enums\ConfirmationChannel;
|
|
use App\Enums\PressReleaseStatus;
|
|
use App\Models\ImageRightsConfirmation;
|
|
use App\Models\PressRelease;
|
|
use App\Models\PressReleaseImage;
|
|
use App\Models\User;
|
|
use App\Services\Image\ImageProvenanceInspector;
|
|
use Database\Seeders\LegalDocumentSeeder;
|
|
use Database\Seeders\LegalTextSeeder;
|
|
use Illuminate\Http\UploadedFile;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Storage;
|
|
use Laravel\Sanctum\Sanctum;
|
|
use Mockery\MockInterface;
|
|
use Tests\TestCase;
|
|
|
|
/**
|
|
* Bildkennzeichnung Block C: v1-Bildupload unter Formular v2 (Pflichtfelder,
|
|
* Kennung des Wortlauts, Bestätigung mit Token-ID, kompatible Response).
|
|
*/
|
|
beforeEach(function (): void {
|
|
/** @var TestCase $this */
|
|
Storage::fake('local');
|
|
$this->seed(LegalDocumentSeeder::class);
|
|
$this->seed(LegalTextSeeder::class);
|
|
config()->set('images.rights_v2', true);
|
|
});
|
|
|
|
function rightsV2ApiDraft(): array
|
|
{
|
|
$user = User::factory()->create();
|
|
$pressRelease = PressRelease::factory()->create([
|
|
'user_id' => $user->id,
|
|
'status' => PressReleaseStatus::Draft->value,
|
|
]);
|
|
|
|
Sanctum::actingAs($user, ['press-releases:read', 'press-release-images:write']);
|
|
|
|
return compact('user', 'pressRelease');
|
|
}
|
|
|
|
function rightsV2ApiFixture(string $name): UploadedFile
|
|
{
|
|
return UploadedFile::fake()->createWithContent($name, (string) file_get_contents(base_path('tests/Fixtures/images/'.$name)));
|
|
}
|
|
|
|
test('credit, confirmation and text version are required under formular v2', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
|
|
$this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", [
|
|
'image' => UploadedFile::fake()->image('foto.jpg', 1200, 800),
|
|
'ai_declaration' => 'original',
|
|
])->assertUnprocessable()
|
|
->assertInvalid(['copyright', 'rights_confirmed', 'confirm_text_version']);
|
|
|
|
expect($pressRelease->images()->count())->toBe(0)
|
|
->and(Storage::disk('local')->allFiles())->toBe([]);
|
|
});
|
|
|
|
test('an outdated text version is rejected with the current key in the message', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
|
|
$response = $this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", [
|
|
'image' => UploadedFile::fake()->image('foto.jpg', 1200, 800),
|
|
'ai_declaration' => 'original',
|
|
'copyright' => 'Muster GmbH',
|
|
'rights_confirmed' => true,
|
|
'confirm_text_version' => 'img-confirm-v1',
|
|
]);
|
|
|
|
$response->assertUnprocessable()->assertInvalid(['confirm_text_version']);
|
|
|
|
expect($response->json('errors.confirm_text_version.0'))->toContain('img-confirm-v2');
|
|
});
|
|
|
|
test('a valid upload stores the confirmation with the token and returns the new fields', function () {
|
|
/** @var TestCase $this */
|
|
// Echter Bearer-Token statt Sanctum::actingAs, damit die Token-ID im
|
|
// Protokoll landet (TransientToken hat keinen Datensatz).
|
|
$user = User::factory()->create();
|
|
$pressRelease = PressRelease::factory()->create(['user_id' => $user->id, 'status' => PressReleaseStatus::Draft->value]);
|
|
$plainToken = $user->createToken('connektar', ['press-releases:read', 'press-release-images:write'])->plainTextToken;
|
|
|
|
$response = $this->withToken($plainToken)->postJson("/api/v1/press-releases/{$pressRelease->id}/images", [
|
|
'image' => rightsV2ApiFixture('xmp-ai-generated.jpg'),
|
|
'ai_declaration' => 'ai_generated',
|
|
'copyright' => 'KI-Bild / Musterfirma',
|
|
'rights_confirmed' => true,
|
|
'confirm_text_version' => 'img-confirm-v2',
|
|
'license_url' => 'https://example.com/lizenz',
|
|
'focus_x' => 20,
|
|
'focus_y' => 80,
|
|
'is_preview' => true,
|
|
], ['User-Agent' => 'ConnektarBot/2.0']);
|
|
|
|
$response->assertCreated()
|
|
->assertJsonPath('data.ai_declaration', 'ai_generated')
|
|
->assertJsonPath('data.ai_declaration_user', 'ai_generated')
|
|
->assertJsonPath('data.ai_declaration_source', 'iptc_prefill')
|
|
->assertJsonPath('data.ai_declaration_locked', false)
|
|
->assertJsonPath('data.provenance_status', 'unsigned_metadata')
|
|
->assertJsonPath('data.license_url', 'https://example.com/lizenz')
|
|
->assertJsonPath('data.rights_confirmation.version', 'img-confirm-v2')
|
|
->assertJsonPath('data.rights_confirmation.agb_version', '0.6')
|
|
->assertJsonPath('data.rights_confirmation.channel', 'api')
|
|
->assertJsonPath('data.warnings', []);
|
|
|
|
$image = PressReleaseImage::query()->sole();
|
|
$confirmation = ImageRightsConfirmation::query()->sole();
|
|
|
|
expect($image->rules_version)->toBe(config('images.rules_version'))
|
|
->and($image->focus_x)->toBe(20)
|
|
->and($image->focus_y)->toBe(80)
|
|
->and($confirmation->channel)->toBe(ConfirmationChannel::Api)
|
|
->and($confirmation->user_id)->toBe($user->id)
|
|
->and($confirmation->personal_access_token_id)->toBe($user->tokens()->sole()->getKey())
|
|
->and($confirmation->user_agent)->toBe('ConnektarBot/2.0')
|
|
->and($response->json('data.urls.original'))->toBe(route('media.press-release-images.show', ['image' => $image->id]))
|
|
->and($response->json('data.path'))->not->toContain('press-release-originals');
|
|
});
|
|
|
|
test('a second title image is rejected with 422 and the press release keeps its first', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
|
|
$payload = fn (string $name) => [
|
|
'image' => UploadedFile::fake()->image($name, 800, 600),
|
|
'ai_declaration' => 'original',
|
|
'copyright' => 'Muster GmbH',
|
|
'rights_confirmed' => true,
|
|
'confirm_text_version' => 'img-confirm-v2',
|
|
];
|
|
|
|
$this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", $payload('eins.jpg'))->assertCreated();
|
|
$this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", $payload('zwei.jpg'))
|
|
->assertUnprocessable()
|
|
->assertJsonPath('errors.image.0', 'Bitte löschen Sie zuerst das vorhandene Titelbild.');
|
|
|
|
expect($pressRelease->images()->count())->toBe(1);
|
|
});
|
|
|
|
test('deleting a never published image via api removes the original and the confirmation', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
|
|
$this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", [
|
|
'image' => UploadedFile::fake()->image('foto.jpg', 800, 600),
|
|
'ai_declaration' => 'original',
|
|
'copyright' => 'Muster GmbH',
|
|
'rights_confirmed' => true,
|
|
'confirm_text_version' => 'img-confirm-v2',
|
|
])->assertCreated();
|
|
|
|
$image = PressReleaseImage::query()->sole();
|
|
|
|
$this->deleteJson("/api/v1/press-release-images/{$image->id}")->assertNoContent();
|
|
|
|
expect(PressReleaseImage::withTrashed()->count())->toBe(0)
|
|
->and(ImageRightsConfirmation::query()->count())->toBe(0)
|
|
->and(Storage::disk('local')->allFiles())->toBe([]);
|
|
});
|
|
|
|
test('the legacy service upload answers 410 with a pointer to v1', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
|
|
$this->postJson("/service/pressreleases/{$pressRelease->id}/images", [
|
|
'press_release_image' => ['image' => UploadedFile::fake()->image('alt.jpg')],
|
|
])->assertStatus(410)
|
|
->assertJsonPath('global_errors.0', fn (string $message) => str_contains($message, '/api/v1/press-releases/{id}/images'));
|
|
|
|
expect($pressRelease->images()->count())->toBe(0);
|
|
});
|
|
|
|
test('the api docs page lists the rights fields with the current text version', function () {
|
|
/** @var TestCase $this */
|
|
$this->get('https://pressekonto.test/de/api')
|
|
->assertSuccessful()
|
|
->assertSeeText('rights_confirmed')
|
|
->assertSeeText('confirm_text_version')
|
|
->assertSeeText('img-confirm-v2');
|
|
});
|
|
|
|
test('a status change during the upload answers 422 and stores nothing', function () {
|
|
/** @var TestCase $this */
|
|
['pressRelease' => $pressRelease] = rightsV2ApiDraft();
|
|
$real = app(ImageProvenanceInspector::class);
|
|
|
|
// Die PM wird während der Herkunftsprüfung eingereicht und veröffentlicht
|
|
// (Audit N07): der Uploader prüft die Statusregel unter der Sperre erneut.
|
|
$this->instance(ImageProvenanceInspector::class, Mockery::mock(ImageProvenanceInspector::class, function (MockInterface $mock) use ($real, $pressRelease): void {
|
|
$mock->shouldReceive('inspect')->andReturnUsing(function (string $path) use ($real, $pressRelease) {
|
|
DB::table('press_releases')->where('id', $pressRelease->id)->update([
|
|
'status' => PressReleaseStatus::Published->value,
|
|
'published_at' => now(),
|
|
]);
|
|
|
|
return $real->inspect($path);
|
|
});
|
|
}));
|
|
|
|
$response = $this->postJson("/api/v1/press-releases/{$pressRelease->id}/images", [
|
|
'image' => rightsV2ApiFixture('plain.png'),
|
|
'ai_declaration' => 'original',
|
|
'copyright' => 'Musterfirma',
|
|
'rights_confirmed' => true,
|
|
'confirm_text_version' => 'img-confirm-v2',
|
|
]);
|
|
|
|
$response->assertStatus(422);
|
|
|
|
expect($response->json('message'))->toContain('Status der Meldung')
|
|
->and(PressReleaseImage::query()->count())->toBe(0)
|
|
->and(ImageRightsConfirmation::query()->count())->toBe(0)
|
|
->and(Storage::disk('local')->allFiles())->toBe([]);
|
|
});
|