presseportale/tests/Feature/PressReleaseClassificationJobTest.php
Kevin Adametz 4419d9ff43 Phase 9 Block 1: Gelb-Routing Direkt-Live, Slot-Verbrauch bei Veroeffentlichung, Submit-Gate
9A — Gelb geht direkt live (Entscheidung 12.06.2026):
- routeByClassification(): Gelb durchlaeuft denselben Auto-Publish-Pfad
  wie Gruen (autoPublishApproved); nur Rot wird abgelehnt
- Scheduler publiziert faellige gelbe + gruene PMs; unklassifizierte
  bleiben als Fallback in der manuellen Queue

9B — Slot-Verbrauch bei Veroeffentlichung (Decision-Update 3.2):
- Increment aus submitForReview() entfernt; publish() und
  changeStatusFromAdmin() zaehlen idempotent beim ersten
  published-Uebergang (Pruefung ueber Status-Logs); Rot kostet nichts
- Submit-Guard: Einreichen erfordert freien Slot
  (QuotaExceededException, API 422)

9C — Submit-Gate vorbereitet (Decision-Update 5.1):
- User::hasActiveBooking()-Stub hinter config/billing.php
  (enforce_booking, Default aus); Tarif-Modul ersetzt nur den Rumpf
- Einreichungs-Modal zeigt ohne Buchung einen Buchungs-Hinweis;
  Server-Guard (BookingRequiredException), API antwortet 402
- Fix: Customer-Create legte PMs bei "Zur Pruefung senden" direkt mit
  Status review an (vorbei an Blacklist/Quota/KI/Status-Log) — laeuft
  jetzt immer ueber submitForReview()

Suite: 451 passed, 4 skipped (9 neue Tests). Pint clean.
Plan: docs/PHASE-9-FLOW-UND-TARIFE-PLAN.md (Block 2 nach Review-Stopp).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-12 09:47:06 +00:00

228 lines
8.2 KiB
PHP

<?php
use App\Enums\PressReleaseClassification;
use App\Enums\PressReleaseStatus;
use App\Jobs\ClassifyPressRelease;
use App\Mail\PressReleasePublished;
use App\Mail\PressReleaseRejected;
use App\Models\KiAudit;
use App\Models\PressRelease;
use App\Models\User;
use App\Services\PressRelease\Classification\ClassificationManager;
use App\Services\PressRelease\PressReleaseService;
use Illuminate\Support\Facades\Http;
use Illuminate\Support\Facades\Mail;
use Illuminate\Support\Facades\Queue;
function fakeOpenAiClassification(string $classification, array $reasons = []): void
{
config()->set('scoring.classification.provider', 'openai');
config()->set('services.openai.api_key', 'test-key');
Http::fake([
'*' => Http::response([
'choices' => [
['message' => ['content' => json_encode([
'classification' => $classification,
'reasons' => $reasons,
])]],
],
], 200),
]);
}
test('classify job stores the openai classification and writes an audit', function () {
fakeOpenAiClassification('green');
$pressRelease = PressRelease::factory()->create(['title' => 'Sauber', 'text' => 'Inhalt']);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$fresh = $pressRelease->fresh();
expect($fresh->classification)->toBe(PressReleaseClassification::Green);
expect($fresh->classified_at)->not->toBeNull();
$audit = KiAudit::where('press_release_id', $pressRelease->id)->firstOrFail();
expect($audit->type)->toBe(KiAudit::TYPE_CLASSIFICATION);
expect($audit->provider)->toBe('openai');
expect($audit->result)->toBe('green');
});
test('classify job records a yellow classification with reasons', function () {
fakeOpenAiClassification('yellow', ['grenzwertige Werbesprache']);
$pressRelease = PressRelease::factory()->create();
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$audit = KiAudit::where('press_release_id', $pressRelease->id)->firstOrFail();
expect($pressRelease->fresh()->classification)->toBe(PressReleaseClassification::Yellow);
expect($audit->reason)->toContain('Werbesprache');
});
test('classify job falls back to the deterministic driver when openai fails', function () {
config()->set('scoring.classification.provider', 'openai');
config()->set('services.openai.api_key', 'test-key');
config()->set('blacklist.words', ['penis']);
Http::fake(['*' => Http::response('error', 500)]);
// Sauberer Text -> deterministischer Fallback liefert green.
$pressRelease = PressRelease::factory()->create(['title' => 'Sauber', 'text' => 'Inhalt']);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$audit = KiAudit::where('press_release_id', $pressRelease->id)->firstOrFail();
expect($pressRelease->fresh()->classification)->toBe(PressReleaseClassification::Green);
expect($audit->provider)->toBe('deterministic');
});
test('deterministic driver classifies a banned word as red', function () {
config()->set('scoring.classification.provider', 'deterministic');
config()->set('blacklist.words', ['penis']);
$pressRelease = PressRelease::factory()->create(['title' => 'Titel penis', 'text' => 'Inhalt']);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$audit = KiAudit::where('press_release_id', $pressRelease->id)->firstOrFail();
expect($pressRelease->fresh()->classification)->toBe(PressReleaseClassification::Red);
expect($audit->provider)->toBe('deterministic');
});
test('classify job routes a red classification to rejected and notifies the author', function () {
Mail::fake();
config()->set('scoring.classification.provider', 'deterministic');
config()->set('blacklist.words', ['penis']);
$author = User::factory()->create();
$pressRelease = PressRelease::factory()->create([
'user_id' => $author->id,
'status' => PressReleaseStatus::Review->value,
'title' => 'Titel penis',
'text' => 'Inhalt',
]);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
expect($pressRelease->fresh()->status)->toBe(PressReleaseStatus::Rejected);
Mail::assertQueued(PressReleaseRejected::class);
});
test('classify job auto-publishes a green classification without a schedule', function () {
Mail::fake();
config()->set('scoring.classification.provider', 'deterministic');
config()->set('blacklist.words', []);
$pressRelease = PressRelease::factory()->create([
'status' => PressReleaseStatus::Review->value,
'scheduled_at' => null,
'title' => 'Sauber',
'text' => 'Inhalt',
]);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
expect($pressRelease->fresh()->status)->toBe(PressReleaseStatus::Published);
Mail::assertQueued(PressReleasePublished::class);
});
test('classify job leaves a green scheduled press release in review for the scheduler', function () {
config()->set('scoring.classification.provider', 'deterministic');
config()->set('blacklist.words', []);
$pressRelease = PressRelease::factory()->create([
'status' => PressReleaseStatus::Review->value,
'scheduled_at' => now()->addWeek(),
'title' => 'Sauber',
'text' => 'Inhalt',
]);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$fresh = $pressRelease->fresh();
expect($fresh->classification)->toBe(PressReleaseClassification::Green);
expect($fresh->status)->toBe(PressReleaseStatus::Review);
});
test('classify job auto-publishes a yellow classification like green', function () {
// Entscheidung 12.06.2026 (Decision-Update §5.0): Gelb geht direkt live,
// es gibt keine manuelle Prüf-Queue — nur Rot wird abgelehnt.
Mail::fake();
fakeOpenAiClassification('yellow', ['grenzwertig']);
$pressRelease = PressRelease::factory()->create([
'status' => PressReleaseStatus::Review->value,
'scheduled_at' => null,
'title' => 'Grenzfall',
'text' => 'Inhalt',
]);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
$fresh = $pressRelease->fresh();
expect($fresh->classification)->toBe(PressReleaseClassification::Yellow);
expect($fresh->status)->toBe(PressReleaseStatus::Published);
Mail::assertQueued(PressReleasePublished::class);
});
test('classify job leaves a yellow scheduled press release in review for the scheduler', function () {
fakeOpenAiClassification('yellow', ['grenzwertig']);
$pressRelease = PressRelease::factory()->create([
'status' => PressReleaseStatus::Review->value,
'scheduled_at' => now()->addWeek(),
'title' => 'Grenzfall',
'text' => 'Inhalt',
]);
(new ClassifyPressRelease($pressRelease->id))->handle(
app(ClassificationManager::class),
app(PressReleaseService::class),
);
expect($pressRelease->fresh()->status)->toBe(PressReleaseStatus::Review);
});
test('submitForReview dispatches the classification job onto the classification queue', function () {
Queue::fake();
config()->set('blacklist.words', []);
$user = User::factory()->create();
$pressRelease = PressRelease::factory()->create([
'user_id' => $user->id,
'status' => PressReleaseStatus::Draft->value,
'title' => 'Sauber',
'text' => 'Inhalt',
]);
app(PressReleaseService::class)->submitForReview($pressRelease);
Queue::assertPushedOn('classification', ClassifyPressRelease::class, function (ClassifyPressRelease $job) use ($pressRelease) {
return $job->pressReleaseId === $pressRelease->id;
});
});