Kevin Adametz
ed1aa07ae6
Auf /admin/me/press-releases wurden bei einem User mit sehr vielen Firmen ~107.000 Company-Models geladen. Ursache: accessibleCompanyIds() nutzte das Eloquent-Relation-pluck() (ownedCompanies()->pluck() / companies()-> pluck()), das pro ID ein vollstaendiges Model hydratisiert. Die Methode wird ueber PressRelease::scopeAccessibleBy() pro Seitenaufruf ~2x ausgewertet (Status-Count- + Listen-Query) -> ~2x 53k Models. Fix: - toBase()->pluck() statt Relation-pluck(): liefert nur die ID-Werte ohne Hydration, wendet die Global Scopes (PortalScope) weiterhin an. - Ergebnis pro Request memoisiert (cachedAccessibleCompanyIds), da der Scope die Methode mehrfach aufruft. Messung (User 14016, 26.772 Firmen): 107.238 -> 24 hydratisierte Company-Models auf der PM-Liste. Ergebnis-IDs unveraendert. Regressionstests: accessibleCompanyIds liefert owned+member ohne Dubletten und hydratisiert 0 Company-Models. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
111 lines
3.8 KiB
PHP
111 lines
3.8 KiB
PHP
<?php
|
|
|
|
use App\Enums\Portal;
|
|
use App\Models\Company;
|
|
use App\Models\PressRelease;
|
|
use App\Models\User;
|
|
use App\Services\CurrentPortalContext;
|
|
use Database\Seeders\RolesAndPermissionsSeeder;
|
|
use Tests\TestCase;
|
|
|
|
beforeEach(function (): void {
|
|
/** @var TestCase $this */
|
|
$this->seed(RolesAndPermissionsSeeder::class);
|
|
});
|
|
|
|
test('accessibleBy includes a users own authored press release', function () {
|
|
$user = User::factory()->create();
|
|
$pr = PressRelease::factory()->create(['user_id' => $user->id, 'company_id' => null]);
|
|
|
|
$ids = PressRelease::accessibleBy($user)->pluck('id');
|
|
|
|
expect($ids)->toContain($pr->id);
|
|
});
|
|
|
|
test('ownedByApiUser matches only the authoring user, not company access', function () {
|
|
$author = User::factory()->create();
|
|
$companyMate = User::factory()->create();
|
|
$company = Company::factory()->create();
|
|
$company->users()->attach($companyMate->id, ['role' => 'member']);
|
|
|
|
$pr = PressRelease::factory()->create(['user_id' => $author->id, 'company_id' => $company->id]);
|
|
|
|
expect(PressRelease::withoutGlobalScopes()->ownedByApiUser($author)->pluck('id'))->toContain($pr->id)
|
|
->and(PressRelease::withoutGlobalScopes()->ownedByApiUser($companyMate)->pluck('id'))->not->toContain($pr->id);
|
|
});
|
|
|
|
test('accessibleBy includes press releases of an assigned company', function () {
|
|
$user = User::factory()->create();
|
|
$company = Company::factory()->presseecho()->create();
|
|
$user->companies()->attach($company->id, ['role' => 'owner']);
|
|
|
|
$other = User::factory()->create();
|
|
$pr = PressRelease::factory()->create([
|
|
'user_id' => $other->id,
|
|
'company_id' => $company->id,
|
|
'portal' => $company->portal->value,
|
|
]);
|
|
|
|
$ids = PressRelease::accessibleBy($user)->pluck('id');
|
|
|
|
expect($ids)->toContain($pr->id);
|
|
});
|
|
|
|
test('accessibleBy excludes press releases of strangers and unrelated companies', function () {
|
|
$user = User::factory()->create();
|
|
$stranger = User::factory()->create();
|
|
$foreignCompany = Company::factory()->presseecho()->create();
|
|
|
|
$foreignPr = PressRelease::factory()->create([
|
|
'user_id' => $stranger->id,
|
|
'company_id' => $foreignCompany->id,
|
|
'portal' => $foreignCompany->portal->value,
|
|
]);
|
|
|
|
$ids = PressRelease::accessibleBy($user)->pluck('id');
|
|
|
|
expect($ids)->not->toContain($foreignPr->id);
|
|
});
|
|
|
|
test('accessibleCompanyIds returns owned and member company ids without duplicates', function () {
|
|
$user = User::factory()->create();
|
|
$owned = Company::factory()->create(['owner_user_id' => $user->id]);
|
|
$member = Company::factory()->create();
|
|
$member->users()->attach($user->id, ['role' => 'member']);
|
|
Company::factory()->create(); // fremde Firma
|
|
|
|
$ids = $user->accessibleCompanyIds();
|
|
|
|
expect($ids)->toEqualCanonicalizing([$owned->id, $member->id]);
|
|
});
|
|
|
|
test('accessibleCompanyIds does not hydrate Company models', function () {
|
|
$user = User::factory()->create();
|
|
Company::factory()->count(3)->create(['owner_user_id' => $user->id]);
|
|
|
|
$hydrated = 0;
|
|
Company::retrieved(function () use (&$hydrated): void {
|
|
$hydrated++;
|
|
});
|
|
|
|
$user->accessibleCompanyIds();
|
|
|
|
expect($hydrated)->toBe(0);
|
|
});
|
|
|
|
test('accessibleBy bypasses the portal global scope so own PMs are visible cross-portal', function () {
|
|
$user = User::factory()->create();
|
|
$pr = PressRelease::factory()->create([
|
|
'user_id' => $user->id,
|
|
'company_id' => null,
|
|
'portal' => Portal::Businessportal24->value,
|
|
]);
|
|
|
|
// Simuliert eingeschränkten Portal-Kontext (Presseecho); der Scope muss
|
|
// die eigene PM dennoch finden, weil er die GlobalScopes entfernt.
|
|
CurrentPortalContext::set(Portal::Presseecho);
|
|
|
|
$found = PressRelease::accessibleBy($user)->find($pr->id);
|
|
|
|
expect($found)->not->toBeNull();
|
|
});
|