presseportale/tests/Feature/Auth/MagicLinkLoginTest.php
Kevin Adametz f06650a641 WS-6: E-Mail-Verifizierung, Auth-Flow-Fixes & Legacy-Rollen-Sicherheitsfix
E-Mail-Verifizierung (Entscheidung 15.06.):
- User implementiert MustVerifyEmail; Registrierung legt inaktives, rollenloses
  Konto an und leitet auf die Danke-/Notice-Seite; Registered-Event versendet die
  Verifizierungsmail. Bestätigter Link aktiviert das Konto + vergibt customer-Rolle
  (ActivateUserAfterVerification). Backfill-Migration setzt email_verified_at für
  alle Bestands-User (sonst würde die verified-Middleware ~59k aktive Legacy-User
  aussperren). Seeder-User verifiziert.

Auth-Flow-Korrekturen:
- Magic-Link-Consume: rollensicherer Redirect ohne intended() (Customer landete
  sonst per stale intended=/dashboard im 403-Admin-Bereich).
- Guest-Redirect (bootstrap/app.php) rollen-/verifizierungsbewusst statt fix
  /dashboard – schließt die 403-Sackgasse auf /login und /register.
- Logout auf der Notice-Seite via echtes POST-Formular statt Livewire-Action
  (behebt 419 beim Session-Invalidate).
- Magic-Link-Anforderung über eigenes Modal mit separater E-Mail-Eingabe.
- Unverifizierte Login-Versuche landen auf der Notice-Seite.

Sicherheitsfix Legacy-Rollen:
- UserImporter mappte Alt-Gruppe 2 (Self-Publisher) auf editor (= Admin-Zugriff).
  Mapping auf customer korrigiert; Daten-Migration stuft die 65.950 fälschlichen
  Legacy-Editoren auf customer herab. Echte admin/api-only bleiben unberührt.

Tests: Registration, EmailVerification, Authentication (Guest-Redirect),
MagicLinkLogin (Modal/Redirect/Regression), Legacy-Import (Gruppen-Mapping).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-06-16 08:16:41 +00:00

166 lines
5.3 KiB
PHP

<?php
use App\Mail\MagicLoginLink;
use App\Models\MagicLink;
use App\Models\User;
use Database\Seeders\RolesAndPermissionsSeeder;
use Illuminate\Support\Facades\Mail;
use Livewire\Volt\Volt as LivewireVolt;
use Tests\TestCase;
test('user can request a magic login link from login page', function () {
Mail::fake();
$user = User::factory()->create(['is_active' => true]);
LivewireVolt::test('auth.login')
->set('magicEmail', $user->email)
->call('sendMagicLink')
->assertHasNoErrors();
Mail::assertSent(MagicLoginLink::class, function (MagicLoginLink $mail) use ($user) {
return $mail->user->is($user) && str_contains($mail->loginUrl, '/magic-login/');
});
$magicLink = MagicLink::query()->firstOrFail();
expect($magicLink->user_id)->toBe($user->id);
expect($magicLink->token_hash)->toHaveLength(64);
});
test('the magic link modal validates its own email field and closes on success', function () {
Mail::fake();
$user = User::factory()->create(['is_active' => true]);
// Leere Eingabe → Validierungsfehler, keine Mail.
LivewireVolt::test('auth.login')
->set('magicEmail', '')
->call('sendMagicLink')
->assertHasErrors(['magicEmail']);
Mail::assertNothingSent();
// Gültige Eingabe → Feld wird geleert, Schließen-Event wird ausgelöst.
LivewireVolt::test('auth.login')
->set('magicEmail', $user->email)
->call('sendMagicLink')
->assertHasNoErrors()
->assertSet('magicEmail', '')
->assertDispatched('magic-link-sent');
});
test('admin can login with a valid magic link and lands on admin dashboard', function () {
/** @var TestCase $this */
$this->seed(RolesAndPermissionsSeeder::class);
Mail::fake();
$user = User::factory()->create(['is_active' => true]);
$user->assignRole('admin');
LivewireVolt::test('auth.login')
->set('magicEmail', $user->email)
->call('sendMagicLink');
$sentMail = null;
Mail::assertSent(MagicLoginLink::class, function (MagicLoginLink $mail) use (&$sentMail) {
$sentMail = $mail;
return true;
});
expect($sentMail)->not->toBeNull();
/** @var MagicLoginLink $sentMail */
$this->get($sentMail->loginUrl)
->assertRedirect(route('dashboard', absolute: false));
$this->assertAuthenticatedAs($user);
expect(MagicLink::query()->firstOrFail()->consumed_at)->not->toBeNull();
$user->refresh();
expect($user->last_login_at)->not->toBeNull();
expect($user->last_login_ip)->toBe('127.0.0.1');
});
test('customer is redirected to me dashboard after magic link login', function () {
/** @var TestCase $this */
$this->seed(RolesAndPermissionsSeeder::class);
Mail::fake();
$customer = User::factory()->create(['is_active' => true]);
$customer->assignRole('customer');
LivewireVolt::test('auth.login')
->set('magicEmail', $customer->email)
->call('sendMagicLink');
$sentMail = null;
Mail::assertSent(MagicLoginLink::class, function (MagicLoginLink $mail) use (&$sentMail) {
$sentMail = $mail;
return true;
});
/** @var MagicLoginLink $sentMail */
$this->get($sentMail->loginUrl)
->assertRedirect(route('me.dashboard', absolute: false));
$this->assertAuthenticatedAs($customer);
});
test('a stale intended admin url does not send a customer into the 403 admin area', function () {
/** @var TestCase $this */
$this->seed(RolesAndPermissionsSeeder::class);
$customer = User::factory()->create(['is_active' => true]);
$customer->assignRole('customer');
$plainToken = 'intended-token';
MagicLink::query()->create([
'user_id' => $customer->id,
'token_hash' => hash('sha256', $plainToken),
'purpose' => 'login',
'expires_at' => now()->addMinutes(5),
]);
// Als Gast zuvor /dashboard besucht → intended-URL liegt in der Session.
$this->withSession(['url.intended' => route('dashboard')]);
$this->get(route('magic-links.consume', ['token' => $plainToken]))
->assertRedirect(route('me.dashboard', absolute: false));
$this->assertAuthenticatedAs($customer);
});
test('expired magic link can not be used', function () {
/** @var TestCase $this */
$user = User::factory()->create(['is_active' => true]);
$plainToken = 'expired-token';
MagicLink::query()->create([
'user_id' => $user->id,
'token_hash' => hash('sha256', $plainToken),
'purpose' => 'login',
'expires_at' => now()->subMinute(),
]);
$this->get(route('magic-links.consume', ['token' => $plainToken]))
->assertRedirect(route('login', absolute: false));
$this->assertGuest();
});
test('consumed magic link can not be reused', function () {
/** @var TestCase $this */
$user = User::factory()->create(['is_active' => true]);
$plainToken = 'consumed-token';
MagicLink::query()->create([
'user_id' => $user->id,
'token_hash' => hash('sha256', $plainToken),
'purpose' => 'login',
'expires_at' => now()->addMinutes(5),
'consumed_at' => now()->subMinute(),
]);
$this->get(route('magic-links.consume', ['token' => $plainToken]))
->assertRedirect(route('login', absolute: false));
$this->assertGuest();
});