- Magic-Link-Login übergibt bei aktiviertem 2FA an die 2FA-Challenge, statt sie zu umgehen (M1). - Bestätigungs-/Benachrichtigungs-Mails (Kontakt, Recht, Kündigung, Widerruf, Magic-Link) laufen als ShouldQueue+afterCommit über die Queue, damit die Response nicht am SMTP-Roundtrip hängt. Hinweis: Der Queue-Worker muss im Betrieb laufen und überwacht werden, da fristrelevante Bestätigungen darüber zugestellt werden (siehe Betriebsüberwachung). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
216 lines
6.9 KiB
PHP
216 lines
6.9 KiB
PHP
<?php
|
|
|
|
use App\Mail\MagicLoginLink;
|
|
use App\Models\MagicLink;
|
|
use App\Models\User;
|
|
use Database\Seeders\RolesAndPermissionsSeeder;
|
|
use Illuminate\Support\Facades\Mail;
|
|
use Livewire\Volt\Volt as LivewireVolt;
|
|
use PragmaRX\Google2FA\Google2FA;
|
|
use Tests\TestCase;
|
|
|
|
test('user can request a magic login link from the magic-link page', function () {
|
|
Mail::fake();
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $user->email)
|
|
->call('requestLink')
|
|
->assertHasNoErrors();
|
|
|
|
Mail::assertQueued(MagicLoginLink::class, function (MagicLoginLink $mail) use ($user) {
|
|
return $mail->user->is($user) && str_contains($mail->loginUrl, '/magic-login/');
|
|
});
|
|
|
|
$magicLink = MagicLink::query()->firstOrFail();
|
|
|
|
expect($magicLink->user_id)->toBe($user->id);
|
|
expect($magicLink->token_hash)->toHaveLength(64);
|
|
});
|
|
|
|
test('the magic link form validates its email field and clears on success', function () {
|
|
Mail::fake();
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
|
|
// Leere Eingabe → Validierungsfehler, keine Mail.
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', '')
|
|
->call('requestLink')
|
|
->assertHasErrors(['email']);
|
|
|
|
Mail::assertNothingOutgoing();
|
|
|
|
// Gültige Eingabe → Feld wird geleert.
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $user->email)
|
|
->call('requestLink')
|
|
->assertHasNoErrors()
|
|
->assertSet('email', '');
|
|
});
|
|
|
|
test('magic link requests are rate limited per email', function () {
|
|
/** @var TestCase $this */
|
|
Mail::fake();
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
|
|
foreach (range(1, 3) as $ignored) {
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $user->email)
|
|
->call('requestLink')
|
|
->assertHasNoErrors();
|
|
}
|
|
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $user->email)
|
|
->call('requestLink')
|
|
->assertHasErrors(['email']);
|
|
|
|
Mail::assertQueued(MagicLoginLink::class, 3);
|
|
});
|
|
|
|
test('admin can login with a valid magic link and lands on admin dashboard', function () {
|
|
/** @var TestCase $this */
|
|
$this->seed(RolesAndPermissionsSeeder::class);
|
|
Mail::fake();
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
$user->assignRole('admin');
|
|
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $user->email)
|
|
->call('requestLink');
|
|
|
|
$sentMail = null;
|
|
|
|
Mail::assertQueued(MagicLoginLink::class, function (MagicLoginLink $mail) use (&$sentMail) {
|
|
$sentMail = $mail;
|
|
|
|
return true;
|
|
});
|
|
|
|
expect($sentMail)->not->toBeNull();
|
|
/** @var MagicLoginLink $sentMail */
|
|
$this->get($sentMail->loginUrl)
|
|
->assertRedirect(route('dashboard', absolute: false));
|
|
|
|
$this->assertAuthenticatedAs($user);
|
|
|
|
expect(MagicLink::query()->firstOrFail()->consumed_at)->not->toBeNull();
|
|
$user->refresh();
|
|
expect($user->last_login_at)->not->toBeNull();
|
|
expect($user->last_login_ip)->toBe('127.0.0.1');
|
|
});
|
|
|
|
test('customer is redirected to me dashboard after magic link login', function () {
|
|
/** @var TestCase $this */
|
|
$this->seed(RolesAndPermissionsSeeder::class);
|
|
Mail::fake();
|
|
$customer = User::factory()->create(['is_active' => true]);
|
|
$customer->assignRole('customer');
|
|
|
|
LivewireVolt::test('auth.magic-link')
|
|
->set('email', $customer->email)
|
|
->call('requestLink');
|
|
|
|
$sentMail = null;
|
|
Mail::assertQueued(MagicLoginLink::class, function (MagicLoginLink $mail) use (&$sentMail) {
|
|
$sentMail = $mail;
|
|
|
|
return true;
|
|
});
|
|
|
|
/** @var MagicLoginLink $sentMail */
|
|
$this->get($sentMail->loginUrl)
|
|
->assertRedirect(route('me.dashboard', absolute: false));
|
|
|
|
$this->assertAuthenticatedAs($customer);
|
|
});
|
|
|
|
test('a stale intended admin url does not send a customer into the 403 admin area', function () {
|
|
/** @var TestCase $this */
|
|
$this->seed(RolesAndPermissionsSeeder::class);
|
|
$customer = User::factory()->create(['is_active' => true]);
|
|
$customer->assignRole('customer');
|
|
|
|
$plainToken = 'intended-token';
|
|
MagicLink::query()->create([
|
|
'user_id' => $customer->id,
|
|
'token_hash' => hash('sha256', $plainToken),
|
|
'purpose' => 'login',
|
|
'expires_at' => now()->addMinutes(5),
|
|
]);
|
|
|
|
// Als Gast zuvor /dashboard besucht → intended-URL liegt in der Session.
|
|
$this->withSession(['url.intended' => route('dashboard')]);
|
|
|
|
$this->get(route('magic-links.consume', ['token' => $plainToken]))
|
|
->assertRedirect(route('me.dashboard', absolute: false));
|
|
|
|
$this->assertAuthenticatedAs($customer);
|
|
});
|
|
|
|
test('magic link login with two-factor enabled is handed to the challenge', function () {
|
|
/**
|
|
* Regression zu Befund M1 (Audit 14.07.2026): Magic-Link darf 2FA nicht
|
|
* umgehen — bei aktivem 2FA wird wie beim Passwort-Login in die Challenge
|
|
* übergeben, statt direkt einzuloggen.
|
|
*/
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
$user->forceFill([
|
|
'two_factor_secret' => encrypt(app(Google2FA::class)->generateSecretKey()),
|
|
'two_factor_confirmed_at' => now(),
|
|
])->save();
|
|
|
|
$plainToken = 'twofactor-token';
|
|
MagicLink::query()->create([
|
|
'user_id' => $user->id,
|
|
'token_hash' => hash('sha256', $plainToken),
|
|
'purpose' => 'login',
|
|
'expires_at' => now()->addMinutes(5),
|
|
]);
|
|
|
|
$this->get(route('magic-links.consume', ['token' => $plainToken]))
|
|
->assertRedirect(route('two-factor.challenge'));
|
|
|
|
$this->assertGuest();
|
|
expect(session('login.id'))->toBe($user->id);
|
|
// Einmal-Nutzung bleibt erhalten: Link ist verbraucht.
|
|
expect(MagicLink::query()->firstOrFail()->consumed_at)->not->toBeNull();
|
|
});
|
|
|
|
test('expired magic link can not be used', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
$plainToken = 'expired-token';
|
|
|
|
MagicLink::query()->create([
|
|
'user_id' => $user->id,
|
|
'token_hash' => hash('sha256', $plainToken),
|
|
'purpose' => 'login',
|
|
'expires_at' => now()->subMinute(),
|
|
]);
|
|
|
|
$this->get(route('magic-links.consume', ['token' => $plainToken]))
|
|
->assertRedirect(route('login', absolute: false));
|
|
|
|
$this->assertGuest();
|
|
});
|
|
|
|
test('consumed magic link can not be reused', function () {
|
|
/** @var TestCase $this */
|
|
$user = User::factory()->create(['is_active' => true]);
|
|
$plainToken = 'consumed-token';
|
|
|
|
MagicLink::query()->create([
|
|
'user_id' => $user->id,
|
|
'token_hash' => hash('sha256', $plainToken),
|
|
'purpose' => 'login',
|
|
'expires_at' => now()->addMinutes(5),
|
|
'consumed_at' => now()->subMinute(),
|
|
]);
|
|
|
|
$this->get(route('magic-links.consume', ['token' => $plainToken]))
|
|
->assertRedirect(route('login', absolute: false));
|
|
|
|
$this->assertGuest();
|
|
});
|